Add next() call to Promise resolutions #213
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a super weird one I encountered while building my app. I noticed when I was logging out and being redirected from `/tracks` to `/login`, the `Tracks` view's `created()` lifecycle hook was being called as I was leaving the page. After adding the `next()` calls as in this PR, it fixed the issue. My only guess is that the `next()` didn't happen quickly enough and that somehow resulted in the view's `created()` lifecycle hook being called, though I'm not really clear on why. Adding the `next()` call worked. And I figured, looking at line 92 (`next(...args)` before the `reject()` call), it made sense to call `next()` before the `resolve()` calls as well.
|
Appreciate the PR @ffxsam! Sorry fro the delay in getting to this, I let the project lapse and currently in the process of trying to bring everything up to date. Since this is a PR for the Vue 2 version of the boilerplate, I'm going to close this so we can focus on the Vue 3 boilerplate going forward. Hope all is well! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a super weird one I encountered while building my app. I noticed when I was logging out and being redirected from
/tracksto/login, theTracksview'screated()lifecycle hook was being called as I was leaving the page. After adding thenext()calls as in this PR, it fixed the issue.My only guess is that the
next()didn't happen quickly enough and that somehow resulted in the view'screated()lifecycle hook being called, though I'm not really clear on why. Adding thenext()call worked. And I figured, looking at line 92 (next(...args)before thereject()call), it made sense to callnext()before theresolve()calls as well.