Allow setting replica interval offsets #523
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll modify this a little as we need an offset for retention check as well. |
If using S3 replicas the extra LIST call on startup may be expensive in scale if a lot of Litestreams are started in quick succession. Allowing configuring the snapshot offset externally allows the caller to spread around the snapshots without relying on access to the remote replica making restarts no-op. Same thing applies to retention checks that they can easily stack too close.
hifi
force-pushed
the
for-upstream/snapshot-offset
branch
from
d6a5f8f
to
4eefea0
Compare
hifi
changed the title
|
Expanded to cover all intervals. We use both snapshot and retention check offsets to prevent storming a bucket with requests around the same time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using S3 replicas the extra LIST call on startup may be expensive in scale if a lot of Litestreams are started in quick succession.
Allowing configuring the snapshot offset externally allows the caller to spread around the snapshots without relying on access to the remote replica making restarts no-op.
Same thing applies to retention checks that they can easily stack too close.