sftp: support ssh certificates #465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbjohnson
reviewed
Mar 30, 2023
Comment on lines
+145
to
+132
| certBuf, err := os.ReadFile(c.KeyPath + "-cert.pub") | ||
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
Should there be a separate certificate path (e.g. c.CertPath)? That seems better than assuming the user has the cert relative to the key path.
There was a problem hiding this comment.
Most SSHy things have kind of a convention around the names of public keys and certs relative to the private key. If you ssh -i ~/foobar, it'll try both the plan key and ~/foobar-cert.pub. That said, there's no harm in being explicit and using a separate config if you'd rather.
There was a problem hiding this comment.
I think I'd prefer it be explicit if the convention isn't required. Also, I'm rolling back replication changes that ended up moving to LiteFS so I'll merge this in after I finish that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was playing around with replicating to another fly.io app.