Fix warnings when compiling with clang

benbarsdell · Jun 18, 2023 · 3cebb2b · 3cebb2b
1 parent dd7948f
commit 3cebb2b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/rtunits.hpp b/rtunits.hpp
@@ -368,6 +368,8 @@ class Dimensions {
       : exponents_({length_, mass_, time_, current_, temperature_, luminosity_,
                     amount_}) {}
 
+  void _war_unused_private_field_warning() const { (void)padding_byte_; }
+
   array_type exponents_;
   value_type padding_byte_ = 0;
 };
@@ -398,6 +400,8 @@ inline std::ostream& operator<<(std::ostream& stream, const Dimensions& dims) {
 
 static_assert(std::is_standard_layout<Dimensions>::value,
               "Internal error: Dimensions is not standard layout");
+static_assert(sizeof(Dimensions) == 8,
+              "Internal error: Dimensions is not exactly 8 bytes");
 
 template <typename T>
 class Quantity {

diff --git a/rtunits_test.cpp b/rtunits_test.cpp
@@ -292,7 +292,7 @@ void test_multi_parsing(std::initializer_list<std::string> symbols,
       for (const auto& sep :
            {" ", "  ", "\t", "*", ",", " * ", " , ", middot, times}) {
         std::string combined_symbol = leading_ws;
-        for (const std::string symbol : symbols) {
+        for (const std::string& symbol : symbols) {
           combined_symbol += symbol + sep;
         }
         combined_symbol += trailing_ws;
@@ -305,7 +305,7 @@ void test_multi_parsing(std::initializer_list<std::string> symbols,
       if (check_with_bad_separators) {
         for (const auto& bad_sep : {"", ".", "-", "&", "|"}) {
           std::string combined_symbol = leading_ws;
-          for (const std::string symbol : symbols) {
+          for (const std::string& symbol : symbols) {
             combined_symbol += symbol + bad_sep;
           }
           combined_symbol += trailing_ws;