Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements (see PR) #298

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

rpeyron
Copy link

@rpeyron rpeyron commented Nov 6, 2022

Hello,

Thanks for your plugin that was very useful to me for my Jekyll migration from WordPress.

I have made some customizations that may interest some other users:

  • added comments export, with three destination possible:
    • as data / collections (to be treated with some liquid)
    • as posts with metadata and markdown as contents
    • as GitHub discussions for use with Giscus
  • added Polylang plugin extraction of languages (and reference to translated pages, and unifying translated categories and tags)
  • added some processing to WordPress contents:
    • remove the site host add by WordPress to get relative URI (useful to test on other hosts before switching)
    • improved code section conversion, specially when using WordPress plugin crayon
    • export image alignment in markdown styles
    • convert spoiler tag to details HTML tag
  • added some metadata and filtered useless ones from oceanwp WordPress theme (list is configurable)
  • and various settings to execute the script outside WordPress folders, to skip some parts of the script (useful to speed-up when running multiple times with posts or script modifications), and to generate without zip in a specific folder

Hope these little things can be useful

Thanks again for the plugin,

Copy link
Owner

@benbalter benbalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request! I like a lot of the intended functionality here and believe it could be useful to others if generalized for other setups. I've left some comments in-line.

If you'd like to see this PR forward, I'd also want to see tests added for any new functionality and it looks like PHPCS is throwing some style errors since I activated CI on this PR.

jekyll-export-cli.php Outdated Show resolved Hide resolved
jekyll-export-cli.php Outdated Show resolved Hide resolved
jekyll-export-cli.php Outdated Show resolved Hide resolved
jekyll-export-cli.php Outdated Show resolved Hide resolved
jekyll-exporter.php Show resolved Hide resolved
jekyll-exporter.php Outdated Show resolved Hide resolved
jekyll-exporter.php Outdated Show resolved Hide resolved
jekyll-exporter.php Outdated Show resolved Hide resolved
jekyll-exporter.php Outdated Show resolved Hide resolved
@rpeyron
Copy link
Author

rpeyron commented Nov 11, 2022

Hello, thanks for your feedback. I have fixed and answered your remarks above.

About tests, do you have some in mind to start with? I certainly won't have time and skills to implement all.
About PHPCS, do you know a linter/formatter for VSCode? Also, it is throwing 700 errors, that is more than the number of line modified, this is crazy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants