Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve native AOT compatibility #222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve native AOT compatibility #222

wants to merge 1 commit into from
+26 −7

Commits on Mar 14, 2024

  1. Improve native AOT compatibility 

    In the end, someone will need to do the work to enable the AOT/trim/single file safety analyzers and [address all the warnings](https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/), but this is enough to have a golden path that makes `sample/StackTrace` project produce the same results under native AOT as under JIT.

Necessary fixes:

* `GetMethodBody` under AOT throws. This will not return anything useful under Mono with ILStrip either. The code simply needs to deal with it.
* Runtime reflection stack doesn't guarantee referential equality of `MemberInfo`s (except for `TypeInfo`). This is also true on JIT-based runtimes, but there's even less caching on native AOT. Use operator `==`.
* The reflection to read `TupleElementNamesAttribute` is trim-unfriendly and cannot be analyzed. Replace with no-reflection.
* Some fallout from the previous point because the nullable annotations on the thing returned by reflection were wrong.
    @MichalStrehovsky
    MichalStrehovsky committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    aa5a37b View commit details
    Browse the repository at this point in the history