Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor GameDisplay #827

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MikuroXina
Copy link
Collaborator

For types, @types/jquery is added and screenfull is bumped.

@MikuroXina MikuroXina self-assigned this Jan 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2023

Codecov Report

Base: 86.39% // Head: 86.21% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (9e8dcce) compared to base (68e0d52).
Patch coverage: 71.54% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #827      +/-   ##
==========================================
- Coverage   86.39%   86.21%   -0.19%     
==========================================
  Files         178      178              
  Lines        5366     5374       +8     
  Branches      382      426      +44     
==========================================
- Hits         4636     4633       -3     
- Misses        676      682       +6     
- Partials       54       59       +5     
Impacted Files Coverage Δ
bemuse/src/game/display/touch3d.ts 6.66% <0.00%> (ø)
bemuse/src/game/state/player-state.ts 86.07% <ø> (ø)
bemuse/src/game/display/player-display.ts 71.30% <71.30%> (ø)
bemuse/src/game/display/Gauge.ts 100.00% <100.00%> (ø)
bemuse/src/game/display/note-area.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarcloud
Copy link

sonarcloud bot commented Jan 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MikuroXina MikuroXina marked this pull request as ready for review January 8, 2023 10:23
@MikuroXina MikuroXina requested a review from dtinth January 8, 2023 10:23
@MikuroXina
Copy link
Collaborator Author

@dtinth Excuse me, could you review my PR? I forgot this.

@dtinth
Copy link
Member

dtinth commented Aug 13, 2023

@MikuroXina Hello, I really apologize. I am currently very occupied with other stuff right now and probably do not have time to develop this project for a few months. 🙏

From a quick glance the code looks good to me, although I can’t play-test the game right now.

For the time being, please feel free to publish a forked version, and feel free to ask me if you need any help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants