Add audit log #1357
Open
Add audit log #1357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelschattgen
force-pushed
the
feature/audit-log
branch
from
18aeffd
to
0994f82
Compare
|
@michaelschattgen A small suggestion is to delete the entries greater than 30 days periodically. |
alexbakker
requested changes
Apr 19, 2024
There was a problem hiding this comment.
This looks great! I've added a couple of comments.
I think the audit log event types you defined cover most of the important events, but I am missing an event for backups made through AegisBackupAgent. Because Android starts backup agents in a weird restricted mode, this one requires some careful testing to make sure it works correctly.
...java/com/beemdevelopment/aegis/ui/fragments/preferences/ImportExportPreferencesFragment.java
Outdated
Show resolved
Hide resolved
...java/com/beemdevelopment/aegis/ui/fragments/preferences/ImportExportPreferencesFragment.java
Show resolved
Hide resolved
...ain/java/com/beemdevelopment/aegis/ui/fragments/preferences/AuditLogPreferencesFragment.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/database/AuditLogEntry.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/views/AuditLogAdapter.java
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/views/AuditLogHolder.java
Outdated
Show resolved
Hide resolved
app/src/main/java/com/beemdevelopment/aegis/ui/AuthActivity.java
Outdated
Show resolved
Hide resolved
michaelschattgen
force-pushed
the
feature/audit-log
branch
from
0994f82
to
a755ec0
Compare
michaelschattgen
force-pushed
the
feature/audit-log
branch
from
a755ec0
to
171da34
Compare
|
I like this feature! I think it should also track when the vault password has been changed. |
|
@elliotwutingfeng I like that! I'm leaving this pull request for what it is (otherwise it will never get done) but that's definitely going on the backlog. Thanks for the suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is aiming to give more insight to important events that occurred within the app. We chose to use a SQLite database in combination with Room. I've made the choice to only show the entries of the last 30 days for now, but we might want to change that in the future.
The events we're currently tracking are:
Feel free to comment on this PR if you think we need to track other events.
This is discussed in #1069 and makes it possible to implement #1132.