[docs] Installation for Windows docs improved #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mairooni
requested changes
May 10, 2024
stratika
requested changes
May 10, 2024
docs/source/installation.rst
Outdated
| cd %USERPROFILE%\MyProjects\TornadoVM | ||
| etc/setvars.cmd | ||
| nmake /f Makefile.mak graal-jdk-21 BACKEND=opencl,ptx | ||
| cd %USERPROFILE%\MyProjects |
There was a problem hiding this comment.
this path may not exist for every user.
| python -m venv .venv | ||
| .venv\Scripts\activate.bat | ||
| .\bin\windowsMicrosoftStudioTools2022.cmd | ||
| python bin\tornadovm-installer --jdk jdk21 --backend=opencl |
There was a problem hiding this comment.
I think this command should change to be:
nmake /f Makefile.mak jdk21 BACKEND=opencl,ptxThe reason is that we are in the section of the manual installation, so we should point to the manual build command.
There was a problem hiding this comment.
I think in the feature we should only allow to install through the installer script. For now, let's maintain the nmake approach as well. I will change this.
Co-authored-by: Thanos Stratikopoulos <34061419+stratika@users.noreply.github.com>
Co-authored-by: Thanos Stratikopoulos <34061419+stratika@users.noreply.github.com>
Co-authored-by: Thanos Stratikopoulos <34061419+stratika@users.noreply.github.com>
Co-authored-by: Thanos Stratikopoulos <34061419+stratika@users.noreply.github.com>
Co-authored-by: Thanos Stratikopoulos <34061419+stratika@users.noreply.github.com>
Co-authored-by: Thanos Stratikopoulos <34061419+stratika@users.noreply.github.com>
|
All comments resolved. |
stratika
approved these changes
May 13, 2024
mairooni
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the documentation for the installation of TornadoVM on Windows 10/11
Problem description
n/ a.
Backend/s tested
Mark the backends affected by this PR.
OS tested
Mark the OS where this PR is tested.
Did you check on FPGAs?
If it is applicable, check your changes on FPGAs.
How to test the new patch?
Link to the documentation.