Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Dockerfile template (fixes beego/bee#712) #713

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Updated Dockerfile template (fixes beego/bee#712) #713

wants to merge 2 commits into from

Conversation

crush-157
Copy link

Updated Dockerfile template to use dep instead of godep.

Also simplified template:

  • used COPY instead of ADD (preferred)
  • used $WORKDIR instead of $APP_DIR (avoids cd'ing and mkdir)

@crush-157
Copy link
Author

Fixes issue #712

@crush-157 crush-157 mentioned this pull request Aug 25, 2020
Open
@crush-157 crush-157 changed the title Updated Dockerfile template Updated Dockerfile template (fixes #712) Aug 25, 2020
@crush-157 crush-157 changed the title Updated Dockerfile template (fixes #712) Updated Dockerfile template (fixes beego/bee#712) Aug 25, 2020
@crush-157 crush-157 changed the title Updated Dockerfile template (fixes beego/bee#712) Updated Dockerfile template fixes beego/bee#712 Aug 25, 2020
@crush-157 crush-157 changed the title Updated Dockerfile template fixes beego/bee#712 Updated Dockerfile template Fixes beego/bee#712 Aug 25, 2020
@crush-157 crush-157 changed the title Updated Dockerfile template Fixes beego/bee#712 Updated Dockerfile template (fixes beego/bee#712) Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@crush-157