New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Guilded webhook regex with tests & added tests for Discord webhooks #247
Conversation
Added Guilded (guilded,gg) webhook regex
Added Discord webhook fixture
Added Discord webhook test
Added Guilded webhook test
Added Guilded webhook fixture
Add in-line mode specifier
Codecov Report
@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 92.60% 92.66% +0.06%
==========================================
Files 15 15
Lines 1217 1227 +10
==========================================
+ Hits 1127 1137 +10
Misses 90 90
Continue to review full report at Codecov.
|
Initial commit had the list meshed together (oops)
Remove trailing comma from Guilded webhook examples
Oops lol
Update test function names
Hopefully fixes black formatting complaints
Can you remove python 3.6 from the github action please? :) |
This has already been done in @amadejpapez's #246 PR, might want to merge it ;) |
@bee-san Any chance of getting this merged? |
Been wondering the same thing for the last year lol |
@IlluminatiFish Hey sorry about this! I see Bee has already approved it :D Merged now 👍 |
All good |
Prerequisites
Why do we need this pull request?
Adds regex for Guilded (guilded.gg) webhooks
Adds fixtures & tests for both Discord (#216) and Guilded webhooks
What GitHub issues does this fix?
Adds tests to #216
Copy / paste of output