Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a typecheck to prevent further errors #773

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dogabudak
Copy link
Contributor

I was using bee-queue and I just realised a stupid mistake I made after long time of research. A more descriptive error would save me a lot of time.

JobId can only be number or string and in a node.js project it is really easy to pass null or even an object as an argument. Maybe this can save some other peoples time.
If you pass any other argument other then string/number you get a generic error from redis-client which is not super helpful.

Screenshot 2024-02-16 at 22 16 22

Copy link
Collaborator

@compwright compwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! It looks like you have some formatting issues in the code change, could you fix those for me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants