Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serialization and deserialization of job errors #41

Closed
wants to merge 1 commit into from

Conversation

perrin4869
Copy link

As discussed in issue #40, for your consideration :)

@LewisJEllis
Copy link
Member

Thanks! At a quick glance it generally looks good, and it seems you've covered your bases on documentation and testing. I'll do a more thorough review tonight.

@AurelienRibon
Copy link

This is a much required feature ! Stack traces are completely lost over the network, making debug process a total pain. Please merge this PR if it works fine, the world will thank you :D

@skeggse
Copy link
Member

skeggse commented Aug 9, 2017

Stack traces are now preserved in the job itself in the job.options.stacktraces Array. I think a more cohesive approach to error serialization that includes both storing this kind of data and publishing is warranted. I like that your solution is pluggable, and would be happy to review a revised PR that also stores the serialized errors in Redis.

@perrin4869
Copy link
Author

Hm... been a long time since I worked on this and have lost interest since... Don't have any plans to update it. You can close it if you want

@bradvogel bradvogel closed this Aug 13, 2017
@samuelgoldenbaum
Copy link

need to get this up and running - really is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants