Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #1350 by properly identifying obfuscated text #2105

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Donovan55
Copy link

@Donovan55 Donovan55 commented Oct 2, 2022

Description

  • Source branch in your fork has meaningful name (not main)

Fixes #1350

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

  • JavaScript implementation
  • Python implementation (NA if HTML beautifier)
  • Added Tests to data file(s)
  • Added command-line option(s) (NA if
  • README.md documents new feature/option(s)

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases showing how this change works to the run_tests method in this same file.

Also update https://github.com/beautify-web/js-beautify/blob/49cd14de2f83e4a2c4c4ed5a3a04077efc17924c/python/jsbeautifier/unpackers/javascriptobfuscator.py#L48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improperly detected unpack deletes part of input
2 participants