Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid json being generated with wrap_line_length #1931

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jseward
Copy link

@jseward jseward commented May 8, 2021

was creating json that split the line between "-" and the numeric value.

ex.

{
  "1234567891234567891234567891234": -
  4
}

Description

  • Source branch in your fork has meaningful name (not main)

Fixes Issue:

Before Merge Checklist

These items can be completed after PR is created.

(Check any items that are not applicable (NA) for this PR)

  • JavaScript implementation
  • Python implementation (NA if HTML beautifier)
  • Added Tests to data file(s)
  • Added command-line option(s) (NA if
  • README.md documents new feature/option(s)

was creating json that split the line between "-" and the numeric value.

ex.

{
  "1234567891234567891234567891234": -
  4
}
@jseward
Copy link
Author

jseward commented May 8, 2021

fixes #1932

@bitwiseman
Copy link
Member

bitwiseman commented May 17, 2021

@jseward
Please add a test similar to this:

https://github.com/beautify-web/js-beautify/blob/9e8db5879af66178d05fc70ba7725fbd1b22aaea/test/data/javascript/tests.js#L218-L230

This will let you set options and test input vs outputs easily and will ensure the test works on both implementations of the beautifier.

You also need to test for "+4", right?

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitwiseman
Copy link
Member

@jseward When do you think you'll get around to working on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants