Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unpack option to js-beautify cli #1232

Closed
wants to merge 3 commits into from

Conversation

hnzlmnn
Copy link

@hnzlmnn hnzlmnn commented Aug 17, 2017

I added a option (-u, --unpack) to the CLI to automatically run the provided unpackers before starting the beautifying process. The option works for the JavaScript and the Python version. All documentation texts i found are updated too.

@bitwiseman
Copy link
Member

@hnzlmnn This is an old PR but fixing it to work with the current codebase would address #1350.

@@ -127,6 +127,7 @@ CLI Options:
-v, --version Show the version

Beautifier Options:
-u, --unpack Try to unpack before beautifying
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-u is already used for unindent-chained-methods.

@bitwiseman
Copy link
Member

@hnzlmnn
Would you be willing to circle back and resolve the merge conflicts here? Also, even if we can use -u this would still be useful.

@bitwiseman
Copy link
Member

This is significantly out of date. I'm going to close. If someone has time to do this later (maybe in relation to #1350), that would be great. But having an open PR is not the way to track this.

@bitwiseman bitwiseman closed this Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants