Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function to get IP representation of subnet mask #95

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

add function to get IP representation of subnet mask #95

wants to merge 4 commits into from

Conversation

drahnieR
Copy link

@drahnieR drahnieR commented Jan 3, 2020

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 3, 2020

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #95   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         623    626    +3     
  Branches       94     94           
=====================================
+ Hits          623    626    +3
Impacted Files Coverage Δ
lib/ipv4.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fe6b67...0bac360. Read the comment docs.

@beaugunderson
Copy link
Owner

beaugunderson commented Jan 5, 2020

@drahnieR thanks, this is a helpful addition--do you mind adding some tests in test/functionality-v4-test.js?

additionally, we should probably return .correctForm() instead of .address

@drahnieR
Copy link
Author

drahnieR commented Jan 6, 2020

Ok, that was a wired failure, but I think i've got the Travis build passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants