Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the 8 Ball Command #574

Merged
merged 2 commits into from
May 5, 2023
Merged

Renamed the 8 Ball Command #574

merged 2 commits into from
May 5, 2023

Conversation

beanbeanjuice
Copy link
Owner

@beanbeanjuice beanbeanjuice commented May 5, 2023

Description

Changed from /8-ball to /8ball. Additionally, fixed the random number generator. It used to return a number between 1 and 3 instead of 0 and 1. For convention, using the latter.

Fixes #572

Type of Change

  • Bug Fix (Small Non-Code Breaking Issue)
  • Bug Fix (Critical Code Breaking Issue)
  • Feature (Something New Added to the Code)
  • Improvement (Improving An Existing Section of Code)
  • Documentation Update
  • Security Vulnerability

Changes

  • Internal Code
  • Documentation
  • Other: _____

Test Configuration:

  • Hardware:
    • CPU: AMD Ryzen 7 3800x @ 4.4Ghz
    • GPU: Nvidia RTX 3080
    • RAM: 32GB DDR4 @ 3600Mhz
  • JDK: Java Oracle OpenJDK 16

Checklist:

  • This pull request has been linked to the appropriate issue on GitHub. (Use the development section on the right.)
  • The code follows the style guidelines.
  • A self-review of the code was performed on GitHub.
  • Appropriate comments and javadocs were added in your code.
  • Appropriate changes have been made to the documentation.
  • Appropriate changes have been made to the README.md file.
  • No warnings are produced when the code is run.
  • Appropriate tests exist for this pull request.
  • New and existing Maven CI tests have passed.
  • The pull request is properly merging into the correct branch.
  • All existing local code has been pushed to the GitHub repository.
  • Changes have been documented in the current draft cafeBot Releases update.

@beanbeanjuice beanbeanjuice added small Something small that can be added/fixed easily. improvement Something to improve the current code. labels May 5, 2023
@beanbeanjuice beanbeanjuice self-assigned this May 5, 2023
@beanbeanjuice beanbeanjuice changed the base branch from master to integration May 5, 2023 07:25
Copy link
Owner Author

@beanbeanjuice beanbeanjuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good.

@beanbeanjuice beanbeanjuice merged commit ce4f93a into integration May 5, 2023
4 checks passed
@beanbeanjuice beanbeanjuice deleted the 572-8ball-rename branch May 5, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something to improve the current code. small Something small that can be added/fixed easily.
Projects
Status: Finished
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Rename /8-ball to /8ball
1 participant