Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

chore: refactor and fix window activation feature #9

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Cercedo
Copy link

@Cercedo Cercedo commented Jul 2, 2023

πŸ“ŒοΈ Task

  • Add development settings.
  • Refactor main.py using black, isort and pycln.
  • Fix activating target windows.
    • Update *.activate(int(time.time)) with *.activate(0).
  • Update the extension logo.
  • Update the README.md

πŸ˜ƒοΈ Notes

This is my first time making a contribution in a public repo. I'd make some changes but feel free to used it if it's required.
Thanks for the extension.

@beajeanm
Copy link
Owner

beajeanm commented Jul 5, 2023

@Cercedo To be honest I haven't used ulauncher or this plugin in years. The changes you've done here look sensible and will probably be an improvement but I don't think I should be the one maintaining this code base anymore.

If you feel like taking over, I suggest that you publish your version on the ulauncher plugin systems, and I will update the description of this plugin to redirect people your way. (A plugin github url cannot be changed, so I can't just transfer the current plugin page to you.)

Hope that helps.

@Cercedo
Copy link
Author

Cercedo commented Jul 6, 2023

Hi @beajeanm

That sounds great. I will consider to do that.
Thank you. 🦾

@beajeanm
Copy link
Owner

beajeanm commented Jul 7, 2023

Ok, cool, let me know when your plugin is up so I can update the description of this one and the README of the repo.

@Cercedo
Copy link
Author

Cercedo commented Jul 21, 2023

Thank you so much. I will. 🦾

@Base-115
Copy link

Really excited about the new plugin refresh! πŸ˜€

@Cercedo
Copy link
Author

Cercedo commented Nov 6, 2023 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants