Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to generate TS string enums #578

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add option to generate TS string enums #578

wants to merge 2 commits into from

Conversation

codan84
Copy link

@codan84 codan84 commented Feb 7, 2024

Linked issue: #200
Addressed comments/requests in: #262 (review)

Implemented as a normalizer under cli/options flag: inferStringEnumKeysFromValues

@codan84 codan84 mentioned this pull request Feb 7, 2024
Open
bcherny
bcherny requested changes Mar 2, 2024
View reviewed changes
Copy link
Owner

@bcherny bcherny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Would you mind adding a couple e2e tests too, so we have a record of the end to end output with this flag enabled?

@codan84
Copy link
Author

codan84 commented Mar 22, 2024

Thanks for the contribution! Would you mind adding a couple e2e tests too, so we have a record of the end to end output with this flag enabled?

Added e2e test

@codan84 codan84 requested a review from bcherny March 22, 2024 11:27
@codan84
Copy link
Author

codan84 commented May 15, 2024

@bcherny ping.
I could really do with this feature being available as we have a lot of issues with tsEnumNames when converting to OpenAPI schema.

@codan84
Copy link
Author

codan84 commented May 20, 2024 •
edited

@bcherny ping 2 - all work and changes requested are completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcherny bcherny Awaiting requested review from bcherny

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@codan84 @bcherny