Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dockerfile for ETL Tool deployment #1149

Merged
merged 3 commits into from
May 15, 2024
Merged

fix: Dockerfile for ETL Tool deployment #1149

merged 3 commits into from
May 15, 2024

Conversation

marcionemec-daitan
Copy link
Collaborator

@marcionemec-daitan marcionemec-daitan commented May 15, 2024 •
edited by github-actions bot

Description

Closes #1148

Changelog

Changed

  • Missing Dockerfile files
  • Disabled test mode (TEST_MODE=0)

How was this tested?

  • 馃 Not needed
  • 馃憖 Eyeball
  • 馃 Added tests

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@marcionemec-daitan marcionemec-daitan linked an issue May 15, 2024 that may be closed by this pull request
Fix dockerfile for ETL Deployment #1148
Closed
@DerekRoberts DerekRoberts marked this pull request as ready for review May 15, 2024 22:51
@DerekRoberts DerekRoberts added bug Something isn't working devops devops related task labels May 15, 2024
@DerekRoberts DerekRoberts force-pushed the fix/1148-fix-dockerfile-for-etl-deployment branch from a8c7cea to 8d85d07 Compare May 15, 2024 23:04
@DerekRoberts DerekRoberts marked this pull request as draft May 15, 2024 23:19
@DerekRoberts DerekRoberts marked this pull request as ready for review May 15, 2024 23:36
@marcionemec-daitan marcionemec-daitan merged commit 59e51d8 into main May 15, 2024
38 of 41 checks passed
@marcionemec-daitan marcionemec-daitan deleted the fix/1148-fix-dockerfile-for-etl-deployment branch May 15, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerekRoberts DerekRoberts DerekRoberts approved these changes

@craigyu craigyu Awaiting requested review from craigyu craigyu is a code owner

@RMCampos RMCampos Awaiting requested review from RMCampos RMCampos is a code owner

@mgaseta mgaseta Awaiting requested review from mgaseta mgaseta is a code owner

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly SLDonnelly is a code owner

Assignees

@DerekRoberts DerekRoberts

@marcionemec-daitan marcionemec-daitan

Labels
bug Something isn't working devops devops related task
Projects
DevOps (NR)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix dockerfile for ETL Deployment
2 participants
@marcionemec-daitan @DerekRoberts