Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: development of seedlot review step 5 interim storage #1145

Merged

Conversation

mgaseta
Copy link
Contributor

@mgaseta mgaseta commented May 15, 2024

Description

Closes #833

Changelog

New

  • Created new Interim read and edit components
  • Added them to the seedlot review view

Changed

  • Added new isReview prop on the ownership step
  • Changed CollectionStep props type name

Removed

  • Unused types associated with interim step

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@mgaseta mgaseta added the front-end front-end related task label May 15, 2024
@mgaseta mgaseta self-assigned this May 15, 2024
@mgaseta mgaseta linked an issue May 15, 2024 that may be closed by this pull request
4 tasks
@mgaseta mgaseta requested a review from ngunner15 May 15, 2024 17:33
@mgaseta mgaseta marked this pull request as ready for review May 22, 2024 16:55
@mgaseta mgaseta marked this pull request as draft May 22, 2024 19:08
@RMCampos
Copy link
Collaborator

Waiting for #1177

@mgaseta mgaseta marked this pull request as ready for review May 23, 2024 21:39
Copy link
Collaborator

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🥇 Only a question!

Copy link
Collaborator

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image

The interim's agency selection does not change if the collector's agency is changed. I suggest that we disable the checkboxes for agency selection on the seedlot review form, let's discuss this with @mmarsoleta on Monday the 27th.

@mgaseta mgaseta requested a review from craigyu May 29, 2024 22:32
@mgaseta mgaseta merged commit 56abcbf into main Jun 3, 2024
27 of 28 checks passed
@mgaseta mgaseta deleted the feat/833-development-of-seedlot-review-step-5---interim-storage branch June 3, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end front-end related task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development of Seedlot Review step 5 - Interim Storage
3 participants