generated from bcgov/quickstart-openshift
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 1083 fetch spz by spu #1127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3-fetch-spz-by-spu
…3-fetch-spz-by-spu # Conflicts: # oracle-api/src/main/java/ca/bc/gov/backendstartapi/endpoint/OrchardEndpoint.java # oracle-api/src/test/java/ca/bc/gov/backendstartapi/endpoint/OrchardEndpointTest.java
craigyu
requested review from
RMCampos,
mgaseta,
DerekRoberts and
SLDonnelly
as code owners
May 14, 2024 18:46
8 tasks
This was
linked to
issues
May 14, 2024
Closed
mgaseta
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
backend/src/main/java/ca/bc/gov/backendstartapi/endpoint/TscAdminEndpoint.java
Outdated
Show resolved
Hide resolved
RMCampos
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Nothing more than suggestions. Please go ahead! 🥇 ⏫
backend/src/main/java/ca/bc/gov/backendstartapi/entity/SeedlotSeedPlanZoneEntity.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ca/bc/gov/backendstartapi/entity/SeedlotSeedPlanZoneEntity.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ca/bc/gov/backendstartapi/entity/SeedlotSeedPlanZoneEntity.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ca/bc/gov/backendstartapi/entity/seedlot/SeedlotOrchard.java
Show resolved
Hide resolved
backend/src/main/java/ca/bc/gov/backendstartapi/exception/GeneticClassNotFoundException.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/ca/bc/gov/backendstartapi/exception/SeedlotConflictDataException.java
Show resolved
Hide resolved
backend/src/main/java/ca/bc/gov/backendstartapi/provider/OracleApiProvider.java
Outdated
Show resolved
Hide resolved
…/nr-spar into feat/1083-fetch-spz-by-spu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #979, #1083
When a seedlot is submitted, the area of use data is fetched from Oracle and then set in Postgres.
Separated the put seedlot form endpoint for normal users and tsc-admin users, although tsc-admin's endpoint is not being used and need more work on it later.
The seedlot service's save seedlot form function now does two more things:
seedlot
tableseedlot
tableChangelog
New
/api/orchards/area-of-use/spu/{spuId}
primary_ind
to theseedlot_seed_plan_zone
table to indicate which spz is the primary, ensures only 1 spz for a seedlot can betrue
primary_ind
for tableseedlot_orchard
, ensures only 1 orchard for a seedlot can be primary, and the seedlot + orchard combination has to be unique. Existing data in that table will have the least updated orchard set as the primary orchard.Changed
/a-class-form-submission
to/a-class-submission
so it's less wordy.updateSeedlotWithForm
isTscAdmin
ensures that only tsc admin can replace records for non pending and incomplete seedlotsstatusOnSuccess
specifies what the status of the seedlot should be upon a successful updateRemoved
How was this tested?
What gif/image best describes this PR or how it makes you feel?
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: