Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: development of seedlot review step 4 ownership #1126

Merged
merged 16 commits into from
May 25, 2024

Conversation

mgaseta
Copy link
Contributor

@mgaseta mgaseta commented May 14, 2024

Description

Closes #857

Changelog

New

  • Created new Ownership read and edit components
  • Added them to the seedlot review view

Changed

  • Added new isReview prop on the ownership step

Removed

  • Nothing :)

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?


Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@mgaseta mgaseta linked an issue May 14, 2024 that may be closed by this pull request
4 tasks
@mgaseta mgaseta self-assigned this May 14, 2024
@mgaseta mgaseta added the front-end front-end related task label May 14, 2024
@mgaseta mgaseta marked this pull request as draft May 14, 2024 17:33
@RMCampos
Copy link
Collaborator

Waiting for #1177

@mgaseta mgaseta marked this pull request as ready for review May 23, 2024 21:39
Copy link
Collaborator

@RMCampos RMCampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 💯 Only one question.

Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

craigyu

This comment was marked as duplicate.

@craigyu craigyu merged commit d19cd59 into main May 25, 2024
28 of 29 checks passed
@craigyu craigyu deleted the feat/857-development-of-seedlot-review-step-4-ownership branch May 25, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end front-end related task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Development of Seedlot Review Step 4 - Ownership
3 participants