Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 1038 update the agency selection input #1096

Merged
merged 25 commits into from
May 16, 2024
Merged

fix: 1038 update the agency selection input #1096

merged 25 commits into from
May 16, 2024

Conversation

mgaseta
Copy link
Contributor

@mgaseta mgaseta commented May 8, 2024 •
edited by github-actions bot

Description

Closes #1038

Changelog

New

  • Added new validation to the agency selection field
  • Added new error banner
  • Added new error messages
  • Added new loading display inside the input

Changed

  • Changed the agency selection method from a dropdown to an input
  • Changed helper texts

Removed

  • Nothing :)

How was this tested?

  • 🧠 Not needed
  • 👀 Eyeball
  • 🤖 Added tests

What gif/image best describes this PR or how it makes you feel?

Thanks for the PR!

Deployments, as required, will be available below:

Please create PRs in draft mode. Mark as ready to enable:

After merge, new images are deployed in:

@mgaseta mgaseta added the front-end front-end related task label May 8, 2024
@mgaseta mgaseta requested a review from ngunner15 May 8, 2024 14:56
@mgaseta mgaseta self-assigned this May 8, 2024
@mgaseta mgaseta linked an issue May 8, 2024 that may be closed by this pull request
update the agency selection input #1038
Closed
@mgaseta mgaseta changed the title Fix:1038 update the agency selection input fix: 1038 update the agency selection input May 8, 2024
@DerekRoberts DerekRoberts deleted the branch main May 13, 2024 23:30
@DerekRoberts DerekRoberts reopened this May 14, 2024
ngunner15
ngunner15 approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@ngunner15 ngunner15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

RMCampos
RMCampos approved these changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@RMCampos RMCampos left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! No changes other than the ones Craig is requesting 🎉

craigyu
craigyu requested changes May 15, 2024
View reviewed changes
Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! ✅
As discussed earlier, a few things needs to be updated:

  • leading 0 on single digit location code
  • cy.wait() usage
  • Green and red circle appearing at the same time

frontend/cypress/e2e/smoke-test/create-a-class-seedlot.cy.ts Outdated Show resolved Hide resolved
@mgaseta mgaseta requested a review from craigyu May 15, 2024 18:49
craigyu
craigyu approved these changes May 16, 2024
View reviewed changes
Copy link
Collaborator

@craigyu craigyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Surprisingly there is no conflict with Nisarg changes ✌️

@mgaseta mgaseta merged commit 702c78d into main May 16, 2024
27 of 28 checks passed
@mgaseta mgaseta deleted the fix/1038-update-the-agency-selection-input branch May 16, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMCampos RMCampos RMCampos approved these changes

@craigyu craigyu craigyu approved these changes

@ngunner15 ngunner15 ngunner15 approved these changes

@DerekRoberts DerekRoberts Awaiting requested review from DerekRoberts DerekRoberts is a code owner

@SLDonnelly SLDonnelly Awaiting requested review from SLDonnelly SLDonnelly is a code owner

Assignees

@mgaseta mgaseta

Labels
front-end front-end related task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update the agency selection input
5 participants
@mgaseta @RMCampos @craigyu @ngunner15 @DerekRoberts