Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: #1270 Add tests verifing business_guid saved for BCeID user #1390

Merged
merged 61 commits into from
May 16, 2024
Merged

chore: #1270 Add tests verifing business_guid saved for BCeID user #1390

merged 61 commits into from
May 16, 2024

Conversation

ianliuwk1019
Copy link
Collaborator

@ianliuwk1019 ianliuwk1019 commented May 14, 2024 •
edited

  • Add fixture "override_target_user_bceid_search" for mocking bceid search parsed return.
  • Add test for user "update"
  • Add tests for idim_proxy integration when search BCeID user by user_guid.
    However, test are skipped as IDIM proxy currently has not enable this yet.
  • Add tests for verifying business_guid is saved for BCeID user when create user role assignment
    and when create delegated admin user.

@ianliuwk1019
WIP - try router help for getting bceid business_id
0e1d4d0
@ianliuwk1019
Merge branch 'main' into exp/depends-for-external-service
8a991db
@ianliuwk1019
Adjust get_target_user_from_id() and add more comment.
67c1d59
@ianliuwk1019
Adjust target_user_bceid_search for use
3c115ac
@ianliuwk1019
Add pytest-mock
cdc5414
@ianliuwk1019
Minor adjustment on target_user_bceid_search
611a1ee
@ianliuwk1019
Merge branch 'main' into exp/depends-for-external-service
dafe154
@ianliuwk1019
Added comment for target_user_bceid_search
b9b5980
@ianliuwk1019
Add Depends(target_user_bceid_search) for create_user_role_assignment…
db9a657 
… and use it to update business_guid.
@ianliuwk1019
Merge branch 'main' into feat/1270-store-update-business-guid
70429b5
@ianliuwk1019
Adjust to use search by guid for idim business bceid search.
d89f5ae
@ianliuwk1019
Fix update user table statement.
e5f8337
@ianliuwk1019
Need UPDATE grant to api_db_user to update user table other than INSERT.
7233bde
@ianliuwk1019
Adjust Requester and TargetUser schema objects.
3efc82e
@ianliuwk1019
Duplicate idim_proxy into admin_management
26419b7
@ianliuwk1019
Add target_user_bceid_search
09f1179
@ianliuwk1019
Add environments for idim
860375e
@ianliuwk1019
Update contact.
a13f5b3
@ianliuwk1019
Migrarte FastAPI exception handler from server/backend and add valida…
b373fc4 
…tion_exception_handler.
@ianliuwk1019
Add ValidationError exception handler
dbe89d1
@ianliuwk1019
Pass target_user to service and fix tests
d9c6d8e
@ianliuwk1019
Add update_user_business_guid to service and to create_access_control…
b1116fc 
…_privilege_many method
@ianliuwk1019
Fixed models import.
62b7041
@ianliuwk1019
Refactor update_user_business_guid to crud_user
25ed8d5
@ianliuwk1019
Pass requester cognito_user_id for updating.
57497e3
@ianliuwk1019
Merge branch 'main' into feat/1270-store-update-business-guid
acecf73
@ianliuwk1019
Use raise_http_exception from util
9ce2c7b
@ianliuwk1019
remove redundant user_guid set.
9187aa3
@ianliuwk1019
Add local environments IDIM_PROXY_BASE_URL and IDIM_PROXY_API_KEY
c784cad
@ianliuwk1019
Add new idim proxy environments to admin_management_api lambda
f26d345
@ianliuwk1019 ianliuwk1019 changed the title chores: #1270 tests chore: #1270 tests May 14, 2024
@ianliuwk1019 ianliuwk1019 marked this pull request as ready for review May 15, 2024 23:28
@MCatherine1994
Copy link
Collaborator

Hi Ian, also wondering shall we rename our pr title?

@ianliuwk1019 ianliuwk1019 changed the title chore: #1270 tests chore: #1270 Add tests verifing business_guid saved for BCeID user. May 16, 2024
@ianliuwk1019
Copy link
Collaborator Author

Hi Ian, also wondering shall we rename our pr title?

Yes, title changed. I only put the main thing although several refactoring was there.
Thanks for reminding that!!

@MCatherine1994 MCatherine1994 changed the title chore: #1270 Add tests verifing business_guid saved for BCeID user. chore: #1270 Add tests verifing business_guid saved for BCeID user May 16, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed for 'nr-forests-access-management_admin'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ianliuwk1019 ianliuwk1019 merged commit e983418 into main May 16, 2024
10 checks passed
@ianliuwk1019 ianliuwk1019 deleted the feat/1270-tests branch May 16, 2024 23:16
@github-actions github-actions bot mentioned this pull request May 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basilv basilv basilv left review comments

@MCatherine1994 MCatherine1994 MCatherine1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ianliuwk1019 @MCatherine1994 @basilv