Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all dependencies assumed to be compatible #173

Merged
merged 3 commits into from
Nov 12, 2019
Merged

Update all dependencies assumed to be compatible #173

merged 3 commits into from
Nov 12, 2019

Conversation

wenzowski
Copy link
Contributor

This leaves four available dependencies unmerged as they have breaking
changes (indicated by semver):

Package                     Current Wanted Latest        Package Type    URL
bootstrap                   3.4.1   3.4.1  4.3.1         dependencies    https://getbootstrap.com/
eslint-config-xo-typescript 0.19.0  0.19.0 0.21.0        devDependencies https://github.com/xojs/eslint-config-xo-typescript#readme
nock                        9.6.1   9.6.1  11.7.0        devDependencies https://github.com/nock/nock#readme
react-jsonschema-form       1.8.0   1.8.0  2.0.0-alpha.1 dependencies    https://github.com/mozilla-services/react-jsonschema-form#readme

^ use yarn outdated to verify

This closes a bunch of dependabot PRs.

@wenzowski
Chore(yarn.lock) update all dependencies assumed to be compatible by …
33c8931 
…semver

This leaves four available dependencies unmerged as they have breaking
changes (indicated by semver):

Package                     Current Wanted Latest        Package Type    URL
bootstrap                   3.4.1   3.4.1  4.3.1         dependencies    https://getbootstrap.com/
eslint-config-xo-typescript 0.19.0  0.19.0 0.21.0        devDependencies https://github.com/xojs/eslint-config-xo-typescript#readme
nock                        9.6.1   9.6.1  11.7.0        devDependencies https://github.com/nock/nock#readme
react-jsonschema-form       1.8.0   1.8.0  2.0.0-alpha.1 dependencies    https://github.com/mozilla-services/react-jsonschema-form#readme
@wenzowski
Copy link
Contributor Author

@matthieu-foucault this fails due to vercel/next.js#5318

@matthieu-foucault
Copy link
Contributor

'next.config.ts' is not supported. Please replace the file with 'next.config.js'. Looks like I went too far with my types. Given that it was silently ignoring the ts config before the update, do we even need the next config?

@matthieu-foucault
Copy link
Contributor

Either way, renaming it to js will solve the issue

@matthieu-foucault
Copy link
Contributor

I'll update eslint-config-xo-typescript in a separate PR, The default config is now disabling some rules which I disabled as well, so I'll clean that up

@wenzowski
Copy link
Contributor Author

I think we want the next config for dotenv support? Would be nice to remove cssmodules support if we're not using them now–they're super buggy (as we discovered) and don't play nice with styled-jsx which we are definitely still using.

@matthieu-foucault
Copy link
Contributor

Maybe just rename the config for now then.

@wenzowski
Fix(next.config.js): rename ts file to js so it isn't ignored by next
3397428 
During the great typescript refactor, this file was renamed as typescript
but next.js doesn't support a typescript config file.

Partial revert of 61bf076
@wenzowski
Copy link
Contributor Author

@matthieu-foucault looks like there type errors caused by adding config.next.js https://circleci.com/gh/bcgov/cas-ciip-portal/4927

Are you good to take that or shall I?

@matthieu-foucault
Copy link
Contributor

I can take a look. Looks like next is ignoring our @ts-ignore annotations now...

@wenzowski
Copy link
Contributor Author

Looks like we were using an unsupported feature with the

{ /*
  // @ts-ignore something
  */ }

pattern, since there's still an open issue about it

@wenzowski
Bugfix(typescript) pin typescript@3.6.4 for @ts-ignore support in jsx
9bce97a 
Use of `@ts-ignore` in jsx expressions is unsupported. Somehow it works
anyway in typescript@3.6.4 so we need to pin until we've resolved the
ignore comments.

Example of unsupported comment:

```
{ /*
  // @ts-ignore something
  */ }
```

see microsoft/TypeScript#31147
@matthieu-foucault
Copy link
Contributor

Sound good. I can see about fixing those errors and upgrading TypeScript in another PR.

@matthieu-foucault matthieu-foucault merged commit 63f3446 into develop Nov 12, 2019
@matthieu-foucault matthieu-foucault deleted the feature/yarn-update branch November 12, 2019 21:43
@matthieu-foucault matthieu-foucault temporarily deployed to wksv3k-dev November 25, 2019 18:36 — with BC CAS Shipit Inactive
@matthieu-foucault matthieu-foucault temporarily deployed to wksv3k-dev November 29, 2019 18:00 — with BC CAS Shipit Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthieu-foucault matthieu-foucault matthieu-foucault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wenzowski @matthieu-foucault