Skip to content

Commit

Permalink
Bugfix(typescript) pin typescript@3.6.4 for @ts-ignore support in jsx
Browse files Browse the repository at this point in the history
Use of `@ts-ignore` in jsx expressions is unsupported. Somehow it works
anyway in typescript@3.6.4 so we need to pin until we've resolved the
ignore comments.

Example of unsupported comment:

```
{ /*
  // @ts-ignore something
  */ }
```

see microsoft/TypeScript#31147
  • Loading branch information
wenzowski committed Dec 10, 2019
1 parent 7ee94a8 commit 911807e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@
"relay-compiler-language-typescript": "^10.1.0",
"relay-test-utils": "^7.0.0",
"require-context.macro": "^1.2.2",
"typescript": "^3.6.4",
"typescript": "3.6.4",
"webpack": "^4.41.0",
"xo": "^0.25.0"
},
Expand Down
8 changes: 4 additions & 4 deletions app/yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -13408,10 +13408,10 @@ typedarray@^0.0.6:
resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=

typescript@^3.6.4:
version "3.7.2"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.7.2.tgz#27e489b95fa5909445e9fef5ee48d81697ad18fb"
integrity sha512-ml7V7JfiN2Xwvcer+XAf2csGO1bPBdRbFCkYBczNZggrBZ9c7G3riSUeJmqEU5uOtXNPMhE3n+R4FA/3YOAWOQ==
typescript@3.6.4:
version "3.6.4"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.6.4.tgz#b18752bb3792bc1a0281335f7f6ebf1bbfc5b91d"
integrity sha512-unoCll1+l+YK4i4F8f22TaNVPRHcD9PA3yCuZ8g5e0qGqlVlJ/8FSateOLLSagn+Yg5+ZwuPkL8LFUc0Jcvksg==

ua-parser-js@^0.7.18:
version "0.7.20"
Expand Down

0 comments on commit 911807e

Please sign in to comment.