Adding compatibility with Pkcs5S2 certificates with HMAC256 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Algorithms SHA-1 and SHA-256 added.
Not use the default HMAC with default SHA1 digest anymore. We use digest indicated in pbeParameters.Prf.Algorithm. Tested with HMAC/SHA1 and HMAC/SHA256 on Pkcs5S2 certificates.
|
I want to write unit tests to verify this fix but I'm only have certificates Pkcs5S2 with HMAC256 from my organization. And I can't publish them. Could anybody tell me how to create a certificate Pkcs5S2 with HMAC256 using BC libraries, please ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not use the default HMAC with default SHA1 digest anymore. We use digest indicated in pbeParameters.Prf.Algorithm. Tested with HMAC/SHA1 and HMAC/SHA256 on Pkcs5S2 certificates.