Revert "Revert "Remove hasAds from service configs""

[tochwill]

Reverts #7294

We have had to revert and block this on #6866, as we had a race condition when setting up the ads bootstrap javascript.

Overall change:
Remove the hasAds field from the service config files and ensure we're just checking the ads toggle from the config endpoint.

Code changes:

• Remove hasAds from the ads object in the service config files
• Move ads object containing the advertisementLabel to the translations object in the service config files
• Remove hasAds checks from the codebase
• Update path to advertisementLabel on amp ads
• Use ToggleContext.Provider with mocked toggle values

[thekp]

I've recently learned that we are using manual mocks for our service context provider. I believe we can also do something similar for the toggles context provider so that in our test environment we use our hardcoded toggle values rather than making any api requests.

[thekp]

I've recently learned that we are using manual mocks for our service context provider. I believe we can also do something similar for the toggles context provider so that in our test environment we use our hardcoded toggle values rather than making any api requests.

I ended up just using ToggleContext.Provider with a mocked set of values rather than mocking the implementation of ToggleContextProvider (like src/app/contexts/ServiceContext/__mocks__/index.jsx). I didn't create a manual mocks because I was getting a duplication warning:

jest-haste-map: duplicate manual mock found: index
  The following files share their name; please delete one of them:
    * <rootDir>/src/app/contexts/ServiceContext/__mocks__/index.jsx
    * <rootDir>/src/app/contexts/ToggleContext/__mocks__/index.jsx

That does not seem officially resolved: jestjs/jest#2070

Passing a mocked set of values means that we do not have to call the fetch api logic in the TogglesContextProvider.

[thekp]

We still get a timeout despite me mocking the ToggleContextProvider 🤕

[DenisHdz]

Great idea on moving the test to this file. Do they pass now on Jenkins?

[mmcculloch]

Yup everything seems stable now! Travis is being a bit weird but I think it's just some issues on their end.

[DenisHdz]

Awesome! There are some conflicts that need to be resolved 🔧

[PriyaKR]

LGTM.