Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to toggle Show Latest On Top #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JiboStore
Copy link

Please merge this push request. It enables Show Latest Log on top, as it may be difficult to keep scrolling through to the bottom to show the latest log

@Kalmalyzer
Copy link
Contributor

Kalmalyzer commented Feb 27, 2019

Thanks for implementing this. However, wouldn't it make more sense to have a "Follow" option? Just like the in-editor console windows? (both the regular Console window and the UberConsole window have this)

[I also notice that the DrawLogListDescending() and DrawLogListAscending() implementations contain a whole lot of duplicated code. If this PR was to be merged - which I'm not sure about, I think a "Follow" option would be better for UberLogger long term - then it should first be rewritten to eliminate the code duplication.]

@bbbscarter
Copy link
Owner

bbbscarter commented Mar 3, 2019

First of all - thanks for this! This is a useful feature.

However, I think I agree; ideally it would be handled the same way as the editor window, unless there's a compelling reason not to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants