Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to toggle showing/hiding channel in log output #42

Closed
wants to merge 2 commits into from

Conversation

astruyk
Copy link
Contributor

@astruyk astruyk commented Feb 26, 2018

This is really handy if you use channels a lot and want to see output from the various channels in the 'all' pane. Otherwise you can only tell what channel output was sent to in the filtered view (in isolation).

…e completion and avoiding having to correct type channel name each time.
@Kalmalyzer
Copy link
Contributor

Kalmalyzer commented Feb 27, 2018

Hi @astruyk , This is a nice feature and something that I have wanted to have for quite some time as well.

When you turn this feature into a PR, please branch off from a branch where you haven't made any other changes yourself (for example, ff8830d on your fork's master branch), put the changes relevant to that feature onto that feature branch, and submit that branch for a PR. If you submit a PR directly fron astruyk:master then the PR-related changes will get clumped in with other changes. For example, the PR for #42 now contains the changes both for #42 and #43. See Doing your work and Submitting a pull request for some standard tips.

Personally, I have a branch called /dev which I treat as my 'local' master branch for internal development purposes. I never put my own changes onto /master. I create PRs by branching off /master and then cherry-picking in the right changesets. Sometimes I update /master from bbbscarter's repo. This allows me to develop and use features internally and gradually publish them to bbbscarter's repo when they are battle-tested.

@astruyk
Copy link
Contributor Author

astruyk commented Feb 27, 2018

Will do. Thanks for the tip. I mostly use git for solo projects so I don't have the workflow down that well. That sounds like a good method for working on forked projects. I'll open a new pull request with just this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants