Improve Python indexing example #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
commented
Feb 28, 2024
| @@ -21,6 +18,14 @@ def _wheel_scanner_impl(target, ctx): | |||
| fail("Didn't have workspace prefix") | |||
| all_py_relative_paths.append(path[len(workspace_root) + 1:]) | |||
| all_py_files.append(file) | |||
| elif ctx.rule.kind == "py_proto_library": | |||
There was a problem hiding this comment.
The main changes are here. Instead of scanning for Python files in wheel, I'm grabbing the first file in DefaultInfo of the target.
There was a problem hiding this comment.
why not add all files and let the command sort it out?
There was a problem hiding this comment.
DefaultInfo#files returns all Python files including from the dependency, so import would end up adding a bunch of unnecessary deps.
eed3si9n
commented
Feb 28, 2024
| @@ -1,4 +1,5 @@ | |||
| import pandas as pd | |||
| from com.example.aa_pb2 import A | |||
There was a problem hiding this comment.
Here's a demo usage.
**Problem** In the current example Python indexing only tracks 3rdparty libraries, but not Protobuf-generated sources. **Solution** This adjusts the scripts to index both 3rdparty pip targets and Protobuf-generated sources.
eed3si9n
force-pushed
the
wip/python_protobuf
branch
from
6654a22
to
208a8e3
Compare
johnynek
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the current example Python indexing only tracks 3rdparty libraries, but not Protobuf-generated sources.
Solution
This adjusts the scripts to index both 3rdparty pip targets and Protobuf-generated sources.