Support protoc-gen-prost-serde in prost_toolchain #2646
+78
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmeku
force-pushed
the
mrmeku-prost-json
branch
3 times, most recently
from
8324f00
to
c22f90c
Compare
This allows users to add serde support for their generated prost proto bindings.
illicitonion
requested changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
protoc-gen-prost-serde is a protoc plugin that generates serde serialization implementations that follow the conventions of protobuf-JSON. Prost does not have JSON bindings itself, so this plugin adds them. Since it is augmenting the structs generated by prost itself, it needs to be part of the same crate which is why I've added it to the existing prost_toolchain