Fix cc_common_link when using sibling repository layout #2643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking with cc_common is broken for external repositories if you also specify
--experimental_sibling_repository_layout
.The rule would complain
The package dir path should be a prefix of the crate_info.output.path
. It happens because the package path derived frombin_dir
,workspace_root
andpackage
did not match how sibling layout handles external repositories.This change ignores the
workspace_root
component if the path signifies the usage of sibling layout, as it is not needed.