IBM Power (ppc64le) support #2091

sumitd2 · 2023-08-01T08:19:06Z

...
//test/unit/utils:utils_tests_test_0                                     PASSED in 0.3s
//test/unit/utils:utils_tests_test_1                                     PASSED in 0.2s
//test/unit/utils:utils_tests_test_2                                     PASSED in 0.4s
//test/unit/utils:utils_tests_test_3                                     PASSED in 0.3s
//test/unit/utils:utils_tests_test_4                                     PASSED in 0.3s
//test/unit/versioned_libs:linux_no_version_test                         PASSED in 0.4s
//test/unit/versioned_libs:linux_suffix_version_test                     PASSED in 0.3s
//test/unit/versioned_libs:versioned_libs_unit_test_suite_test_0         PASSED in 0.3s
//test/versioned_dylib:versioned_dylib_test                              PASSED in 0.4s
//tools/runfiles:runfiles_test                                           PASSED in 0.4s
//tools/rust_analyzer:gen_rust_project_lib_test                          PASSED in 0.5s
//util/label:label_test                                                  PASSED in 0.4s
//util/process_wrapper:process_wrapper_test                              PASSED in 0.5s

Executed 321 out of 341 tests: 321 tests pass and 20 were skipped.

Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>

UebelAndre

Sorry for the delay! Had a couple of questions for this one.

UebelAndre · 2023-08-24T15:55:24Z

crate_universe/private/vendor_utils.bzl

@@ -66,6 +73,7 @@ def crates_vendor_deps_targets():
        actual = select({
            ":linux_amd64": "@cargo_bazel.buildifier-linux-amd64//file",
            ":linux_arm64": "@cargo_bazel.buildifier-linux-arm64//file",
+            ":linux_ppc64le": "@cargo_bazel.buildifier-linux-amd64//file",


This doesn't seem correct. The amd64 binary can run on a powerpc CPU?

Hi @UebelAndre Apologies for the late response, I got assigned to another project.
This one does look like a mistake. But it suggests buildifier was not required at all when I built and tested on my local ppc64le VM. Wondering where it is being used with your Intel builds?

UebelAndre · 2023-08-24T15:56:08Z

cargo/private/cargo_build_script.bzl

@@ -87,6 +87,7 @@ def _cargo_build_script_impl(ctx):
    flags_out = ctx.actions.declare_file(ctx.label.name + ".flags")
    link_flags = ctx.actions.declare_file(ctx.label.name + ".linkflags")
    link_search_paths = ctx.actions.declare_file(ctx.label.name + ".linksearchpaths")  # rustc-link-search, propagated from transitive dependencies
+    link_search_prefix = "%s" % (ctx.label.workspace_root) if toolchain.target_arch == "powerpc64le" else ""


Can you explain this change?

@UebelAndre I had to make this change because one of the required C libraries was not getting found at the expected location. A prefix had to be added to the path but only for the power build and not the Intel build. Please allow me some time to recollect the name of the library and other specifics.

@UebelAndre The library in question is rustix_outline_powerpc64.
The path that was going in with -L was src/backend/linux_raw/arch/outline/release/
It should be external/cui__rustix-0.37.23/src/backend/linux_raw/arch/outline/release , because the library was at the location /root/.cache/bazel/_bazel_root/ff51cf56844f3e41f238392435809bdf/external/cui__rustix-0.37.23/src/backend/linux_raw/arch/outline/release/librustix_outline_powerpc64.a

I hope this makes sense.

UebelAndre · 2023-08-24T15:56:30Z

cargo/cargo_build_script_runner/lib.rs

@@ -187,7 +191,13 @@ impl BuildScriptOutput {
                BuildScriptOutput::Flags(e) => compile_flags.push(e.to_owned()),
                BuildScriptOutput::LinkArg(e) => compile_flags.push(format!("-Clink-arg={e}")),
                BuildScriptOutput::LinkLib(e) => link_flags.push(format!("-l{e}")),
-                BuildScriptOutput::LinkSearch(e) => link_search_paths.push(format!("-L{e}")),
+                BuildScriptOutput::LinkSearch(e) => {


Can you explain this change as well?

@UebelAndre I had to make this change because one of the required C libraries was not getting found at the expected location. A prefix had to be added to the path but only for the power build and not the Intel build. Please allow me some time to recollect the name of the library and other specifics.

sumitd2 · 2023-09-15T15:13:45Z

cc: @seth-priya

sumitd2 and others added 2 commits August 1, 2023 04:17

IBM Power (ppc64le) support

bac9c99

Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>

Merge branch 'main' into ppc64le

79c19b2

sumitd2 mentioned this pull request Aug 2, 2023

How to build and test rules_rust #2060

Open

sumitd2 and others added 17 commits August 2, 2023 10:21

Update cargo_build_script.bzl - fix order

c85adb2

Update BUILD.linux-raw-sys-0.3.8.bazel, fix order

468e7b0

Update repositories.bzl, fix order

80d98e3

Update bin.rs, fix indentation

8f5a52b

Update lib.rs, fix indentation

1e196dd

Test only

424b00f

Test only

6d5eb75

Test only

e0dd3f5

Update lib.rs, provision for empty link_search_prefix

650dd8b

link_search_prefix to be blank for arch other than powerpc64le

fe1e4ab

Update cargo_build_script.bzl

063b476

Update cargo_build_script.bzl

f0e3580

Update lib.rs

e4207b5

Update lib.rs

a8fd888

Update lib.rs

233ee5e

Update docs

14a64f8

Merge branch 'main' into ppc64le

f7c8b80

UebelAndre requested changes Aug 24, 2023

View reviewed changes

Merge branch 'bazelbuild:main' into ppc64le

738ee2c

sumitd2 added 3 commits October 10, 2023 12:56

Merge branch 'main' into ppc64le

1f2f5a5

Update triple.bzl

e0d6e51

Update triple.bzl

b4e021f

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IBM Power (ppc64le) support #2091

IBM Power (ppc64le) support #2091

sumitd2 commented Aug 1, 2023

UebelAndre left a comment

UebelAndre Aug 24, 2023

sumitd2 Sep 15, 2023

UebelAndre Aug 24, 2023

sumitd2 Sep 15, 2023 •

edited

sumitd2 Oct 10, 2023

UebelAndre Aug 24, 2023

sumitd2 Sep 15, 2023 •

edited

sumitd2 commented Sep 15, 2023

IBM Power (ppc64le) support #2091

Are you sure you want to change the base?

IBM Power (ppc64le) support #2091

Conversation

sumitd2 commented Aug 1, 2023

UebelAndre left a comment

Choose a reason for hiding this comment

UebelAndre Aug 24, 2023

Choose a reason for hiding this comment

sumitd2 Sep 15, 2023

Choose a reason for hiding this comment

UebelAndre Aug 24, 2023

Choose a reason for hiding this comment

sumitd2 Sep 15, 2023 • edited

Choose a reason for hiding this comment

sumitd2 Oct 10, 2023

Choose a reason for hiding this comment

UebelAndre Aug 24, 2023

Choose a reason for hiding this comment

sumitd2 Sep 15, 2023 • edited

Choose a reason for hiding this comment

sumitd2 commented Sep 15, 2023

sumitd2 Sep 15, 2023 •

edited

sumitd2 Sep 15, 2023 •

edited