feat: add whl_filegroup #1904
Merged
feat: add whl_filegroup #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aignas
reviewed
May 17, 2024
|
Aside from the pending comments, this looks pretty good. Thanks! |
rickeylev
requested changes
May 18, 2024
rickeylev
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
whl_filegrouprule which can take a wheel as input and extract it, making theoutput available to consumers. A pattern is allowed to better control what files
are extracted.
This is handy to, e.g. get the numpy headers from the numpy wheel so they can be
used in a cc_library. e.g.,
Closes #1903
Fixes #1311