use dedicated exec group for link actions #3711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
force-pushed
the
sluongng/link-exec-group
branch
5 times, most recently
from
aeaba9e
to
700170b
Compare
When remote execution is used, a user may want to use different
exec properties for different actions under the same target.
For example:
A go_test could include 3 different actions:
- GoCompilePkg
- GoLink
- GoTest
If users wish to use a special exec_properties for GoLink actions,
after this PR, they could do so with:
```python
go_test(
...
exec_properties = {
# Default
"container-image": "docker://alpine",
"EstimatedMemory": "500MB",
# Only applied to GoLink exec_group
"GoLink.container-image": "docker://ubuntu",
"GoLink.EstimatedMemory": "2GB",
}
...
)
```
Reference: https://bazel.build/extending/exec-groups
sluongng
force-pushed
the
sluongng/link-exec-group
branch
from
700170b
to
0331319
Compare
|
This seems to be a breaking change for downstream rules that consume rules_go action directly (i.e. gazelle_binary.bzl). The solution is those rules must declare exec_groups in the rules declaration in order to consume the action 🤔 I don't really see a way around it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When remote execution is used, a user may want to use different
exec properties for different actions under the same target.
For example:
A go_test could include 3 different actions:
If users wish to use a special exec_properties for GoLink actions,
after this PR, they could do so with:
Reference: https://bazel.build/extending/exec-groups
What type of PR is this?
What does this PR do? Why is it needed?
Which issues(s) does this PR fix?
Fixes #
Other notes for review