New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use aspect to infer proto deps automatically #3706
base: master
Are you sure you want to change the base?
Conversation
@fmeum Could I have your input on this? I am quite new to Bazel and therefore any input is highly appreciated! The approach in this PR is to generate the go proto bindings within an aspect on the So any input to my general approach or ideas on how to move forward is highly appreciated! |
One idea which I just had is to use separate aspects for compilers (might still share the same implementation but need to set the |
@fmeum I would really appreciate your help here. Thanks in advance! |
Sorry for the delay, I do really appreciate your work on this. I can't promise that I will get to this before BazelCon as I'm somewhat busy preparing for it. I am not that knowledgeable about gRPC, so I will have to delve into that a bit before I can provide meaningful input. CC @linzhp just in case you already have some ideas in mind |
Thanks for your answer. Take your time. Looking forward for your comments. |
|
Isn't this exactly what I am doing? I tried to base my implementation on the Python one... Please correct me if I mix things up or chose the wrong words as I am still quite new to Bazel and especially aspects. |
e9cb3cd
to
b51cfe9
Compare
to org_golang_google_protobuf and org_golang_google_grpc.
This is best practice in order to avoid clashing with other aspects who also want to generate go libraries
What type of PR is this?
What does this PR do? Why is it needed?
This automatically infers transitive proto deps with an aspect to avoid manually maintaining two parallel dependency trees (proto deps and go_proto deps).
Which issues(s) does this PR fix?
Fixes #3668
Other notes for review
Testing repository: https://github.com/mering/test-rules-go