Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop "Dependency adapters for virtual targets". #281

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lberki
Copy link
Contributor

@lberki lberki commented Dec 6, 2022

As discussed on #16380, the potential benefits given the alternatives of doing this in a FUSE (or NFS-as-FUSE on Mac OS) file system or teaching bazel query to recursively determine transitive dependencies and the difficulty of designing an interface that is simple enough, performant enough and stable enough is considerable.

@lberki lberki requested a review from jin as a code owner December 6, 2022 08:24
@lberki lberki requested review from haxorz and removed request for jin December 6, 2022 08:25
@lberki
Copy link
Contributor Author

lberki commented Dec 6, 2022

cc @vdye @newren

@vdye
Copy link
Contributor

vdye commented Dec 6, 2022

As discussed on #16380, the potential benefits given the alternatives of doing this in a FUSE (or NFS-as-FUSE on Mac OS) file system or teaching bazel query to recursively determine transitive dependencies and the difficulty of designing an interface that is simple enough, performant enough and stable enough is considerable.

To be clear, I don't agree with these statements and they're not an accurate representation of why I decided to stop discussing upstreaming efforts. To quote my last comment in bazelbuild/bazel#16380:

at the moment, we seem to have reached an impasse on the necessity and approach to this feature.

While I've accepted that you have no desire to properly support this use case (further evidenced by the fact that you closed the issue without addressing my ask to keep it open for others to discuss), please do not misrepresent my reasons for stepping away from that issue. I still fully believe that dependency resolution APIs (in one form or another) can be cleanly integrated into Bazel and that FUSE or "magicdeps()" are not acceptable replacements. However, the Bazel team has uniformly dismissed the underlying concerns that prompted the initial proposal, so any collaboration or integration with the upstream project is evidently a non-starter.

I am not interested in continuing this argument. I am simply asking that you do not conclude that the proposed alternatives provided a satisfactory resolution to the issue; they did not.

CC: @sluongng, @maxious, @linzhp

@lberki
Copy link
Contributor Author

lberki commented Dec 6, 2022

Actually, managed to skim over the half-sentence asking for the issue to be kept open and it makes total sense. Sorry about that. Bug reopened.

It's not an accurate representation of my point of view to say that I "dismissed the underlying concerns"; I am fully aware what limitations the alternatives I proposed have. But I am also aware of the limitations every design proposed on bazelbuild/bazel#16380 has. And the better the alternatives are, the less motivation there is to continue the work on better alternatives because the maximum possible upside is limited by how bad the alternatives are.

As discussed on #16380, the potential benefits given the alternatives of
doing this in a FUSE (or NFS-as-FUSE on Mac OS) file system or teaching
`bazel query` to recursively determine transitive dependencies and the
difficulty of designing an interface that is simple enough, performant
enough and stable enough is considerable.
@lberki lberki force-pushed the lberki-drop-dependency-adapters branch from f46d033 to 89be406 Compare March 30, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants