Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel-compile-commands-extractor@0.0.0-20240315-5bcb0bd #1989

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 9, 2024

@bazel-io
Copy link
Member

bazel-io commented May 9, 2024

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (bazel-compile-commands-extractor) have been updated in this PR. Please review the changes.

@fmeum fmeum added presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR labels May 9, 2024
@mmorel-35 mmorel-35 force-pushed the bazel-compile-commands-extractor@0.0.0-20221115-dc36e46 branch 2 times, most recently from ca5abde to 92992e9 Compare May 12, 2024 08:50
@mmorel-35 mmorel-35 marked this pull request as draft May 16, 2024 07:03
@mmorel-35 mmorel-35 changed the title bazel-compile-commands-extractor@0.0.0-20221115-dc36e46 bazel-compile-commands-extractor@0.0.0-20240315-5bcb0bd May 16, 2024
@mmorel-35 mmorel-35 force-pushed the bazel-compile-commands-extractor@0.0.0-20221115-dc36e46 branch from 83ff630 to 2df46ed Compare May 16, 2024 08:04
@mmorel-35 mmorel-35 marked this pull request as ready for review May 16, 2024 08:05
@mmorel-35
Copy link
Contributor Author

@fmeum ,
Are you the person to review this ?

@fmeum
Copy link
Contributor

fmeum commented May 16, 2024

As the repo already has a MODULE.bazel, we should coordinate this with the maintainer.

CC @cpsauer

@cpsauer
Copy link

cpsauer commented May 16, 2024

Thanks, Fabian. Offhand, I think we'd rather just continue distributing directly as git_override, since it's a dev dependency, to save bookkeeping for everyone and keep living at head. [i.e. propose closing.] I'll work with Matthieu on the in-repo PR to try to understand and fix the underlying problem.

Cheers!
Chris

@fmeum fmeum closed this May 17, 2024
@mmorel-35 mmorel-35 deleted the bazel-compile-commands-extractor@0.0.0-20221115-dc36e46 branch May 17, 2024 07:49
@mmorel-35 mmorel-35 restored the bazel-compile-commands-extractor@0.0.0-20221115-dc36e46 branch May 18, 2024 09:34
@mmorel-35 mmorel-35 deleted the bazel-compile-commands-extractor@0.0.0-20221115-dc36e46 branch May 18, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants