Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed xplane sdk linking #1938

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

Attempt3035
Copy link
Contributor

Fixed windows & mac linking (worked on 6.#.# but needs rules_apple for 7.#.#)

Does anyone know if there's a way to use rules_apple and apple_support without requiring the end user to depend on apple_support in the top level project module? I know apple_support sets toolchain settings, but it would be great if it could be done just within the module.

I only get successful builds by also having bazel_dep(name = "apple_support", version = "1.15.1") in the project's module.bazel that depends on xplane_sdk

@fmeum
Copy link
Contributor

fmeum commented May 3, 2024

The apole_support/bazel_tools toolchain situation is unfortunate, but we're trying to improve this for Bazel 8. Right now, there is nothing you can do to force this for the root module.

Cc @brentleyjones

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label May 3, 2024
… (although apple support is needed in top level dependant)
@Attempt3035
Copy link
Contributor Author

@fmeum Any idea why rules_apple isn't being found in the BCR in builds?

@fmeum
Copy link
Contributor

fmeum commented May 12, 2024

Your branch is not up-to-date: https://github.com/dynacondev/bazel-central-registry/tree/xplane_sdk/modules/rules_apple
Rebasing onto main should solve this.

* main: (321 commits)
  aspect_rules_lint@0.21.0 (bazelbuild#2014)
  aspect_rules_js@2.0.0-alpha.6 (bazelbuild#2012)
  rules_rust@0.44.0 (bazelbuild#2011)
  contrib_rules_jvm@0.26.0 (bazelbuild#2007)
  aspect_rules_js@2.0.0-alpha.5 (bazelbuild#2010)
  aspect_rules_lint@0.20.0 (bazelbuild#2008)
  Update `tree-sitter-bazel` to `0.22.6`. (bazelbuild#2006)
  aspect_rules_jasmine@2.0.0-alpha.0 (bazelbuild#1999)
  aspect_rules_webpack@0.15.0-alpha.0 (bazelbuild#2003)
  aspect_rules_jest@0.21.0-alpha.0 (bazelbuild#2002)
  aspect_rules_rollup@2.0.0-alpha.0 (bazelbuild#2000)
  aspect_rules_esbuild@0.20.0-alpha.0 (bazelbuild#1998)
  aspect_rules_ts@3.0.0-alpha.0 (bazelbuild#2004)
  aspect_rules_swc@2.0.0-alpha.0 (bazelbuild#2001)
  aspect_rules_js@2.0.0-alpha.4 (bazelbuild#1997)
  rules_xcodeproj@2.3.1 (bazelbuild#1996)
  Bump validators from 0.20.0 to 0.28.1 in /tools (bazelbuild#1990)
  rules_xcodeproj@2.3.0 (bazelbuild#1993)
  Update .bazelversion to 7.1.2 (bazelbuild#1983)
  Add SourceKitten 0.35.0 (bazelbuild#1981)
  ...
@Attempt3035
Copy link
Contributor Author

Oh of course 🤦‍♀️🤦‍♀️ Thank you!

@Attempt3035
Copy link
Contributor Author

@fmeum Do I need to do something special to have the build runner use apple cc toolchain? (Like to depend on apple_support at the top level). Apple support is already a dep in the module file itself

Error in fail: Invalid target triple: local, this likely means you're using the wrong CC toolchain, make sure you include apple_support in your project

@fmeum
Copy link
Contributor

fmeum commented May 12, 2024

The regular C++ toolchain takes precedence without an explicit bazel_dep in the top-level module.

@keith @brentleyjones How do you usually work around this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants