sdl@2.0.8 #1887
sdl@2.0.8 #1887
Conversation
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (sdl) have been updated in this PR. Please review the changes. |
mmorel-35
force-pushed
the
sdl@2.0.8
branch
3 times, most recently
from
1250b16
to
a7a28f0
Compare
| + linkopts = select({ | ||
| + "@platforms//os:linux": ["-lSDL2"], | ||
| + "//conditions:default": [], | ||
| + }), |
There was a problem hiding this comment.
Is there a reason sdl is using system installed SDL2 for linux and being compiled for macos?
There was a problem hiding this comment.
I took everything from quic-trace.
If you have something more complete and opened for other users feel free to provide it. Maybe through a PR that can replace mine, I don't mind
There was a problem hiding this comment.
I took everything from quic-trace.
Understandable.
I think there's a few sdl2 build files out there. I would like it in the BCR, but I think it should be a little more complete than the one in quic-trace. I don't have one off hand, but I have some old ones https://github.com/bazelregistry/sdl2/blob/main/BUILD.bazel that I could maybe combine with the quic-trace one to make something more complete. I don't know when I'll be able to do it though.
There was a problem hiding this comment.
I shall be able to give it a try by the end of the week.
| +module( | ||
| + name = "sdl", | ||
| + version = "2.0.8", | ||
| +) |
There was a problem hiding this comment.
probably should add a compatibility number as 2?
| platform: ${{ platform }} | ||
| bazel: ${{ bazel }} | ||
| build_flags: | ||
| - '--cxxopt=-std=c++17' |
There was a problem hiding this comment.
this would probably be better added in the copts of the cc_library instead of as a build flag in the presubmit.
| - debian10 | ||
| - ubuntu2004 | ||
| - macos | ||
| - macos_arm64 |
There was a problem hiding this comment.
ideally Windows is also supported
|
hey @mmorel-35 I did some major work to get SDL running with bzlmod if you want to check it out here: https://github.com/zaucy/SDL (it has tests as well!) Currently it just has Windows support, but I plan to add other platforms as well. If you want to contribute (especially on the macOS side) that would be really helpful. It was quite the challenge to get the SDL config to generate based on bazels config settings, but it seems to be working so far. I've opened up issues/discussion on my repo if you want to chat about it more. |
Release: https://github.com/libsdl-org/SDL/releases/tag/release-2.0.8
Used by: