-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPHINX based html docs #418
Conversation
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 8 8
Lines 560 560
Branches 79 79
=======================================
Hits 552 552
Misses 4 4
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Generally this is looking really good imo! Two small things I noticed is that a) you're listed as copyright holder of the package in the footer and b) in the constrained optimization notebook, there seems to be a problem with importing Are the notebooks re-rendered on commit/new PR? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
I don't think it is, I was just checking whether you had some bigger strategy for getting this set up |
Hi @fmfn and @till-m
As discussed, I drafted a html based documentation.
All source code is in the 'docsrc' directory.
To build the docs, navigate to this directory, install the requirements listed in the requirements file and do
make github
.This will generate a folder called docs. In this folder, open
index.html
in a browser to review the documents.The documents are made of two things:
docsrc/examples.rst
).docsrc/code_docs.rst
)I have also added a workflow that will build these docs, and eventually publish them to new branch (
.github/workflows/build_docs.yml
). We can then use github pages to host the docs directly from this branch. However @fmfn will have to implement a lot of these steps as they require admin rights - but we can do that when we get to it. For now let me know what you think of the draft html.Future documents can be written in notebooks, markdown, or rst - and then incorporated into the html.