New bridge-domain-based L3 adjacencies model #8246
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move to a more granular model with reified state functions associated with edges.
Major differences over old "new l3 adjacencies" algorithm:
- add nodes for L2 interfaces instead of overloading physical interfaces
- split L3 interface into bridged and non-bridged variants
- support multiple tag-handling l2/l3 interfaces on the same physical interface
- allow multiple bridge domains per node
- use typed edges between nodes, where each edge contains a state function
- restrict the type of operations that can be performed on each edge type
Other notable features:
- disable each interface with subinterfaces that allow overlapping input tags
- add modeling support for individual trunk interfaces attached to multiple bridge domains
- Add InterfaceTopology to each interface encompassing tag-handling and bridging configuration
- Must be populated prior by end of conversion
- Add legacy helpers to populate interface topology for existing vendors
- Replaces switchport/encapuslation settings as source of truth for behavior
- Existing settings preserved as informational
arifogel
requested review from
dhalperi,
anothermattbrown,
corinaminer and
sfraint
|
This change is |
arifogel
commented
Apr 14, 2022
There was a problem hiding this comment.
Reviewable status: 0 of 131 files reviewed, 1 unresolved discussion (waiting on @anothermattbrown, @corinaminer, @dhalperi, and @sfraint)
a discussion (no related file):
self-merge only
Codecov Report
@@ Coverage Diff @@
## master #8246 +/- ##
============================================
- Coverage 74.57% 74.54% -0.03%
- Complexity 43706 44168 +462
============================================
Files 3403 3471 +68
Lines 169347 170965 +1618
Branches 20225 20441 +216
============================================
+ Hits 126289 127447 +1158
- Misses 33489 33812 +323
- Partials 9569 9706 +137
|
arifogel
removed request for
dhalperi,
anothermattbrown,
corinaminer and
sfraint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to a more granular model with reified state functions associated with edges.
Major differences over old "new l3 adjacencies" algorithm:
Other notable features: