Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit docs cleanup and remove reference to Truss 201 #835

Open
wants to merge 32 commits into
base: main
Choose a base branch
from

Conversation

vshulman
Copy link
Contributor

  • Cleaned up some inconsistencies in references
  • Added S3 as supported cache source (it was already referenced elsewhere in the doc)
  • Removed reference to Truss 201 as it doesn't seem to exist yet

@vshulman vshulman changed the title nit cleanup and remove reference to Truss 201 nit docs cleanup and remove reference to Truss 201 Feb 24, 2024
Copy link
Collaborator

@bolasim bolasim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be dropping all the TGI and vLLM stuff in this PR btw. Shouldn't prevent you from merging this, just pointing it out.

Copy link
Member

@philipkiely-baseten philipkiely-baseten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thank you! Please merge when ready.

squidarth and others added 25 commits February 26, 2024 10:15
* Allow using generic types in output annotation.

* Small cleanup.
* Addind configuration to set the streaming request timeout

* Adding test case

* Adding more robust test case

* Adding test case to check error in log file
* minor copy update

* correct TensorFlow capitalization
…ram (#829)

* [RFC][POC] Run truss server as normal python process

* WIP: control server

* Working draft server

* Fix tests

* WIP: continue fixing tests; issue with patch typing

* Fix some mypy issues

* Clean up some more imports

* Move test files

* Move some things around for readabliity

* Cleanup everything except fs in tests

* Only 4 tests left

* Revert changes to test data

* Fix all unit tests

* Drop unnecessary config dump

* Fix some integration tests; move packages dir

* Clean up logging and patches

* Fix packages path for TRT

* Fix issue holding control server integration tests from passing

* Fix rest of integration tests

* Fix unit test and drop test_durations

* Fix last integration test by passing APP_HOME and adding to path
…#834)

* [RFC][POC] Run truss server as normal python process

* WIP: control server

* Working draft server

* Fix tests

* WIP: continue fixing tests; issue with patch typing

* Fix some mypy issues

* Clean up some more imports

* Move test files

* Move some things around for readabliity

* Cleanup everything except fs in tests

* Only 4 tests left

* Revert changes to test data

* Fix all unit tests

* Drop unnecessary config dump

* Fix some integration tests; move packages dir

* Clean up logging and patches

* Fix packages path for TRT

* Fix issue holding control server integration tests from passing

* Fix rest of integration tests

* Fix unit test and drop test_durations

* Fix last integration test by passing APP_HOME and adding to path

* Clean old templates, training code, deprecated serveres, and examples

* reset vscode settings

* Fix integration test using example
…es (#812)

Although we currently account for truss ignore patterns when detecting file changes with watchfiles.watch, we do not 
account for the ignore patterns when calculating patches or the truss hash and signature. This means that changes in 
ignored files will still be patched. This PR fixes that, along with some refactoring and bug fixes.
* add pathspec to pyproject

* poetry lock --no-update

* fix calc_patch call
This changes the `os.PathLike[Any]` annotation to `os.PathLike`. `os.PathLike` isn't subscriptable in Python 3.8, so 
`os.PathLike[Any]` results in `TypeError: 'ABCMeta' object is not subscriptable`.
If a user doesn't provide a .truss_ignore in their truss directory, fall back to the default .truss_ignore file specified in the 
truss package.
* Move build configuration script to truss

* Update pyproject.toml

* Move build configuration script to truss

* Update pyproject.toml

* Fix unintentially ignore build directory
* Move log to response.

* Shorten log message.
* minor copy update (#838)

* minor copy update

* correct TensorFlow capitalization

* Refactor `truss.server` out of templates to run as normal python program (#829)

* [RFC][POC] Run truss server as normal python process

* WIP: control server

* Working draft server

* Fix tests

* WIP: continue fixing tests; issue with patch typing

* Fix some mypy issues

* Clean up some more imports

* Move test files

* Move some things around for readabliity

* Cleanup everything except fs in tests

* Only 4 tests left

* Revert changes to test data

* Fix all unit tests

* Drop unnecessary config dump

* Fix some integration tests; move packages dir

* Clean up logging and patches

* Fix packages path for TRT

* Fix issue holding control server integration tests from passing

* Fix rest of integration tests

* Fix unit test and drop test_durations

* Fix last integration test by passing APP_HOME and adding to path

* Clean old templates, training code, deprecated serveres, and examples (#834)

* [RFC][POC] Run truss server as normal python process

* WIP: control server

* Working draft server

* Fix tests

* WIP: continue fixing tests; issue with patch typing

* Fix some mypy issues

* Clean up some more imports

* Move test files

* Move some things around for readabliity

* Cleanup everything except fs in tests

* Only 4 tests left

* Revert changes to test data

* Fix all unit tests

* Drop unnecessary config dump

* Fix some integration tests; move packages dir

* Clean up logging and patches

* Fix packages path for TRT

* Fix issue holding control server integration tests from passing

* Fix rest of integration tests

* Fix unit test and drop test_durations

* Fix last integration test by passing APP_HOME and adding to path

* Clean old templates, training code, deprecated serveres, and examples

* reset vscode settings

* Fix integration test using example

* Improve `truss watch`: respect `.truss_ignore` when calculating patches (#812)

Although we currently account for truss ignore patterns when detecting file changes with watchfiles.watch, we do not 
account for the ignore patterns when calculating patches or the truss hash and signature. This means that changes in 
ignored files will still be patched. This PR fixes that, along with some refactoring and bug fixes.

* Fix integration tests (#843)

* add pathspec to pyproject

* poetry lock --no-update

* fix calc_patch call

* Fix os.PathLike type annotation

This changes the `os.PathLike[Any]` annotation to `os.PathLike`. `os.PathLike` isn't subscriptable in Python 3.8, so 
`os.PathLike[Any]` results in `TypeError: 'ABCMeta' object is not subscriptable`.

* Fall back to default .truss_ignore in truss upload

If a user doesn't provide a .truss_ignore in their truss directory, fall back to the default .truss_ignore file specified in the 
truss package.

* Move build configuration script to truss (#847)

* Move build configuration script to truss

* Update pyproject.toml

* Move build configuration script to truss

* Update pyproject.toml

* Fix unintentially ignore build directory

* Bump version to 0.10.0-rc.0

---------

Co-authored-by: Philip Kiely - Baseten <98474633+philipkiely-baseten@users.noreply.github.com>
Co-authored-by: Bola Malek <bola@baseten.co>
Co-authored-by: helenlyang <helen.yang@baseten.co>
* Revert "Move build configuration script to truss (#847)"

This reverts commit 7271f87.

* Revert "Refactor `truss.server` out of templates to run as normal python program (#829)"

This reverts commit 8b1bf5d.
* Convert TRT-LLM config to pydantic v1 and add integration tests for running user models with both pydantic v1 and v2.

* Test.
Copy link
Member

@philipkiely-baseten philipkiely-baseten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spring cleaning!

I reviewed the docs and examples changes which look good, the CLI changes should get looked at by another engineer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants