Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs]: add gelato vrf #492

Merged
merged 6 commits into from
May 25, 2024
Merged

[docs]: add gelato vrf #492

merged 6 commits into from
May 25, 2024

Conversation

anirudhmakhana
Copy link
Contributor

What changed? Why?
Added Gelato VRF to oracles section of the tools docs.

wbnns
wbnns requested changes May 14, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anirudhmakhana

Hi there! Thanks for adding this! Can you please omit the changes to data.json from this PR?

@cb-heimdall
Copy link
Collaborator

Review Error for wbnns @ 2024-05-14 22:52:27 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@zencephalon
Copy link
Collaborator

@anirudhmakhana Instead of deleting data.json could U just not introduce any changes to it? Thank U!

@wbnns wbnns added the state: backlog This is pending further review label May 22, 2024
wbnns
wbnns approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anirudhmakhana

Thanks!

@wbnns wbnns added state: in progress This is being worked on and removed state: backlog This is pending further review labels May 23, 2024
zencephalon
zencephalon previously requested changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@zencephalon zencephalon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave data.json alone, it's currently being deleted

@cb-heimdall
Copy link
Collaborator

Review Error for zencephalon @ 2024-05-23 16:51:38 UTC
User failed mfa authentication, see go/mfa-help

@wbnns wbnns added the change(s) requested One or more changes have been requested label May 23, 2024
@wbnns wbnns self-assigned this May 23, 2024
wbnns
wbnns approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped the artifact

@cb-heimdall
Copy link
Collaborator

Review Error for wbnns @ 2024-05-24 10:51:43 UTC
User cannot review their own commit

@wbnns wbnns removed the change(s) requested One or more changes have been requested label May 24, 2024
@wbnns wbnns dismissed zencephalon’s stale review May 25, 2024 12:01

Requested changes made 👍

@wbnns wbnns merged commit 5ea931f into base-org:master May 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbnns wbnns wbnns approved these changes

@rcbgr rcbgr rcbgr approved these changes

@zencephalon zencephalon zencephalon left review comments

Assignees

@wbnns wbnns

Labels
state: in progress This is being worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anirudhmakhana @cb-heimdall @zencephalon @wbnns @rcbgr