Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sequence to onboarding docs #464

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

taylanpince
Copy link

What changed? Why?
Adding Sequence to onboarding docs.

Notes to reviewers
N/A

How has it been tested?
Links have been tested, Sequence added in alphabetical order following convention.

Does this PR add a new token to the bridge?
No

Are you adding an entry to assets.ts?

  • No, this PR does not add a new token to the bridge
  • Yes, and I've confirmed this token doesn't use a bridge override
  • Yes, and I've confirmed this token is an OptimismMintableERC20

If you are adding a token to the bridge, please include evidence of both confirmations above for your reviewers.

Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taylanpince

Thanks for the PR! Left one requested change. Also, do you all have a Base-specific landing page you can link to instead of the homepage?

@@ -54,6 +55,12 @@ You can [get started with Privy here](https://docs.privy.io/guide/quickstart), a

---

## Sequence

[Sequence](https://sequence.xyz/) is the leading all-in-one development platform for integrating web3 into games. Onboard, monetize, grow, and retain players with Sequence’s award-winning technology including: non-custodial Embedded Wallets, white labeled marketplaces and marketplace API, indexer, relayer, node gateway, Unity/Unreal/React Native/Mobile SDKs, transaction API, contract deployment, analytics, and more. [Learn more here](https://sequence.xyz/) and start creating on [Sequence Builder](https://sequence.build/) now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please drop the superlative (s/a leading/the leading)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbnns Thank you for the quick review! Both changes are added now.

@wbnns wbnns added the state: backlog This is pending further review label Apr 27, 2024
@taylanpince taylanpince requested a review from wbnns April 30, 2024 11:19
Copy link
Member

@wbnns wbnns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taylanpince

Thanks! The landing page looks good! Can you please change:

the all-in-one to an all-in-one (remove superlative)

@cb-heimdall
Copy link
Collaborator

Review Error for wbnns @ 2024-04-30 11:58:09 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@taylanpince
Copy link
Author

@taylanpince

Thanks! The landing page looks good! Can you please change:

the all-in-one to an all-in-one (remove superlative)

Done ✅

@taylanpince taylanpince requested a review from wbnns April 30, 2024 20:34
@taylanpince
Copy link
Author

@wbnns Do you need anything else from our end to finalize this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: backlog This is pending further review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants