Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Base Camp Invalid chain ID error (#349) #350

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

twynne20
Copy link
Contributor

@twynne20 twynne20 commented Mar 6, 2024

What changed? Why?

  • The error message displayed when connecting to the wrong network while tracking progress with Base Camp has been updated.
  • The previous error message was not clear and informative enough, lacking guidance for users on how to resolve the issue.
  • The updated error message now clearly communicates that the user is connected to an unsupported network, provides the specific chain ID, and instructs them to connect to the Base Sepolia network.

Notes to reviewers

  • Please review the updated error message in the useNFTData function in the nft-exercise-data.js file.
  • Ensure that the error message is clear, concise, and actionable, guiding users to switch to the Base Sepolia network.
  • Consider any additional feedback or suggestions to further improve the user experience.

How has it been tested?

  • The changes have been tested locally by intentionally connecting to an unsupported network and verifying that the new error message is displayed correctly.
  • The specific chain ID of the unsupported network is included in the error message.
  • The error message instructs the user to connect to the Base Sepolia network.

Does this PR add a new token to the bridge?

  • No, this PR does not add a new token to the bridge
  • I've confirmed this token doesn't use a bridge override
  • I've confirmed this token is an OptimismMintableERC20

Please include evidence of both confirmations above for your reviewers.

@twynne20
Copy link
Contributor Author

twynne20 commented Mar 6, 2024

Link to the issue #349 opened for this.

@briandoyle81CB briandoyle81CB merged commit 0d5de81 into base-org:master Mar 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants