Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update contract verification docs to be more precise #345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update contract verification docs to be more precise #345

wants to merge 1 commit into from

Conversation

kaseLunt
Copy link
Contributor

@kaseLunt kaseLunt commented Mar 5, 2024

What changed? Why?

  • Updated the "Contract Verification" article in response to issue #342
  • Added direct links to sepolia.basescan.org throughout the article for clarity
  • Clarified language to ensure users understand they should use sepolia.basescan.org for contract verification and interaction on the Base Sepolia testnet
  • Improved sentence structure and overall flow while maintaining all necessary information

Notes to reviewers

How has it been tested?

  • Reviewed the updated article for clarity, accuracy, and completeness
  • Tested all links to ensure they lead to the correct pages on sepolia.basescan.org
  • Followed the updated instructions to verify and interact with a contract on sepolia.basescan.org to confirm the process works as described

Does this PR add a new token to the bridge?

  • [x ] No, this PR does not add a new token to the bridge
  • I've confirmed this token doesn't use a bridge override
  • I've confirmed this token is an OptimismMintableERC20

@wbnns
Copy link
Member

wbnns commented Mar 6, 2024

@kaseLunt

Thanks for taking the time to open this PR! We've added this to our backlog, pending to be reviewed.

@wbnns wbnns added the state: backlog This is pending further review label Mar 6, 2024
briandoyle81CB
briandoyle81CB reviewed Mar 8, 2024
View reviewed changes
apps/base-docs/base-camp/docs/deployment-to-testnet/contract-verification-sbs.md

You can interact with your deployed contract using Remix, the same as before, but it's also possible to interact with it through Etherscan. Paste your address in the search field to find it.
While you can interact with your deployed contract using Remix, you can also do so through [sepolia.basescan.org](https://sepolia.basescan.org). To find your contract, paste its address into the search field and click search.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change to reference-style links. See below for an example!

briandoyle81CB
briandoyle81CB requested changes Mar 8, 2024
View reviewed changes
Copy link
Collaborator

@briandoyle81CB briandoyle81CB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is a great PR! Requesting a couple minor changes

@wbnns
Copy link
Member

wbnns commented Apr 10, 2024

@kaseLunt Hi there! Since it's been some time since @briandoyle81CB left feedback without further changes, just wanted to follow-up to see if you were still interested in pursuing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@briandoyle81CB briandoyle81CB briandoyle81CB requested changes

@zencephalon zencephalon zencephalon approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
state: backlog This is pending further review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kaseLunt @wbnns @zencephalon @briandoyle81CB